Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ACPI to set fan speeds #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow ACPI to set fan speeds #309

wants to merge 1 commit into from

Conversation

curiousercreative
Copy link
Contributor

@curiousercreative curiousercreative commented Oct 17, 2022 •
edited
Loading

  • Relays ACPI writes to ACPI fan variables
  • Fan speeds will be a smoothed maximum of what EC would set and what ACPI has requested.
  • Needs testing, ACPI requested speeds that differ when multiple fans present may override the EC fan syncing, which should be okay. If userspace wants control, allow them to control the fan speeds independently.

Futher discussion/consideration should be had on:

  • Should EC set fan speed floors or not spin fans at all? I currently have EC set floors.
  • Should EC be responsible for smoothing fan speeds when ACPI values are used? I currently have EC smoothing always, but this yields poor pwmconfig detection. A PR exists for not smoothing ACPI values here
  • Depending on the above, we should revisit the existing fan curves and perhaps make them far more conservative and push any fan speed "performance" concerns to userspace.

Relates to:

@curiousercreative curiousercreative force-pushed the acpi-fans branch 5 times, most recently from a201bcf to 109a1d3 Compare October 17, 2022 17:27
@curiousercreative curiousercreative marked this pull request as ready for review October 17, 2022 17:31
This was referenced Oct 17, 2022
Open
Open
Open
@curiousercreative curiousercreative force-pushed the acpi-fans branch 2 times, most recently from 3a683aa to b1a2679 Compare October 18, 2022 14:35
@curiousercreative curiousercreative mentioned this pull request Oct 18, 2022
Open
@crawfxrd crawfxrd requested review from jackpot51 and a team January 19, 2023 16:24
@curiousercreative
Copy link
Contributor Author

rebased and tested on my galp5

ilikenwf added a commit to ilikenwf/ec that referenced this pull request Sep 11, 2023
@ilikenwf
https://github.com/system76/ec/pull/309
e42ae14
@curiousercreative
allow ACPI to set fan speeds
55bc539 
Smooth ACPI fan pwm values same as EC fan curve points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 Awaiting requested review from jackpot51

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@curiousercreative