Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make laptop fan duty pwm writable #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

curiousercreative
Copy link
Contributor

@curiousercreative curiousercreative commented Oct 17, 2022

All sysfs paths assume that /sys/class/hwmon/hwmon3/name === "system76_acpi", so check which /sys/class/hwmon/hwmonX is the one for your system.

  1. makes /sys/class/hwmon/hwmon3/pwm1 and /sys/class/hwmon/hwmon3/pwm2 (where available) writable. Write 0-255 to set a desired fan speed where 255 = 100%.
  2. When writes are received to sysfs, we forward to ACPI methods SFD0 and SFD1 which should get forwarded all the way to the EC fans controller. (SFD = Set Fan Duty)

Further discussion/consideration needed for:

  • how to range clamp the values written to sysfs? or should we return an error?
  • should we also make pwn_enable writable and pass that all the way through to the EC?

Relates to (requires for new functionality, shouldn't break though):

Along with related PRs, would resolve/improve:

@curiousercreative curiousercreative force-pushed the master branch 2 times, most recently from 52385fc to 82fed28 Compare October 17, 2022 16:02
@curiousercreative curiousercreative marked this pull request as ready for review October 17, 2022 17:14
@curiousercreative curiousercreative changed the title add build and install instructions to README, make fan speeds writable Make laptop fan duty pwm writable Oct 18, 2022
@curiousercreative
Copy link
Contributor Author

curiousercreative commented Jul 11, 2023

@crawfxrd crawfxrd requested review from a team August 18, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant