Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_batcher): add tests and refactor batcher_test #2640

Open
wants to merge 1 commit into
base: 12-05-refactor_starknet_batcher_delete_the_proposal_manager
Choose a base branch
from

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.47%. Comparing base (cfc0dcc) to head (2556745).

Files with missing lines Patch % Lines
crates/starknet_batcher_types/src/batcher_types.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           12-05-refactor_starknet_batcher_delete_the_proposal_manager   #2640      +/-   ##
==============================================================================================
+ Coverage                                                         6.40%   6.47%   +0.06%     
==============================================================================================
  Files                                                              141     141              
  Lines                                                            17135   17136       +1     
  Branches                                                         17135   17136       +1     
==============================================================================================
+ Hits                                                              1098    1109      +11     
+ Misses                                                           15962   15956       -6     
+ Partials                                                            75      71       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from 5879b0d to c948824 Compare December 10, 2024 14:53
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from c948824 to 2556745 Compare December 10, 2024 14:56
@dafnamatsry dafnamatsry marked this pull request as ready for review December 10, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants