Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_batcher): delete the proposal manager #2618

Open
wants to merge 1 commit into
base: 12-10-refactor_starknet_batcher_move_around_some_types_and_utils_to_a_common_utils_file
Choose a base branch
from

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 67.53247% with 25 lines in your changes missing coverage. Please review.

Project coverage is 6.40%. Comparing base (3bc9a7f) to head (cfc0dcc).

Files with missing lines Patch % Lines
crates/starknet_batcher/src/batcher.rs 67.53% 20 Missing and 5 partials ⚠️
Additional details and impacted files
@@                                                    Coverage Diff                                                     @@
##           12-10-refactor_starknet_batcher_move_around_some_types_and_utils_to_a_common_utils_file   #2618      +/-   ##
==========================================================================================================================
- Coverage                                                                                     6.52%   6.40%   -0.12%     
==========================================================================================================================
  Files                                                                                          142     141       -1     
  Lines                                                                                        17181   17135      -46     
  Branches                                                                                     17181   17135      -46     
==========================================================================================================================
- Hits                                                                                          1121    1098      -23     
+ Misses                                                                                       15983   15962      -21     
+ Partials                                                                                        77      75       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch 2 times, most recently from c0673ad to 1b75381 Compare December 10, 2024 10:44
@dafnamatsry dafnamatsry changed the base branch from 12-04-refactor_starknet_batcher_validate_flow_refactor to 12-10-refactor_starknet_batcher_move_around_some_types_and_utils_to_a_common_utils_file December 10, 2024 10:44
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 1b75381 to 65f45b2 Compare December 10, 2024 11:40
@dafnamatsry dafnamatsry marked this pull request as ready for review December 10, 2024 11:41
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 65f45b2 to cfc0dcc Compare December 10, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants