-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(starknet_batcher): move around some types and utils to a common utils file #2622
base: 12-04-refactor_starknet_batcher_validate_flow_refactor
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 12-04-refactor_starknet_batcher_validate_flow_refactor #2622 +/- ##
=========================================================================================
+ Coverage 6.49% 6.52% +0.02%
=========================================================================================
Files 141 142 +1
Lines 17182 17181 -1
Branches 17182 17181 -1
=========================================================================================
+ Hits 1116 1121 +5
+ Misses 15989 15983 -6
Partials 77 77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @Yael-Starkware)
crates/starknet_batcher/src/utils.rs
line 24 at r1 (raw file):
pub(crate) enum ProposalError { #[error(transparent)] BlockBuilderError(Arc<BlockBuilderError>),
BlockBuilderError has an Aborted variant. Can we use it and remove the ProposalError completely?
No description provided.