Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_batcher): move around some types and utils to a common utils file #2622

Open
wants to merge 1 commit into
base: 12-04-refactor_starknet_batcher_validate_flow_refactor
Choose a base branch
from

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.

Project coverage is 6.52%. Comparing base (fe25e29) to head (3bc9a7f).

Files with missing lines Patch % Lines
crates/starknet_batcher/src/utils.rs 85.52% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@                                    Coverage Diff                                    @@
##           12-04-refactor_starknet_batcher_validate_flow_refactor   #2622      +/-   ##
=========================================================================================
+ Coverage                                                    6.49%   6.52%   +0.02%     
=========================================================================================
  Files                                                         141     142       +1     
  Lines                                                       17182   17181       -1     
  Branches                                                    17182   17181       -1     
=========================================================================================
+ Hits                                                         1116    1121       +5     
+ Misses                                                      15989   15983       -6     
  Partials                                                       77      77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafnamatsry dafnamatsry marked this pull request as ready for review December 10, 2024 10:53
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @Yael-Starkware)


crates/starknet_batcher/src/utils.rs line 24 at r1 (raw file):

pub(crate) enum ProposalError {
    #[error(transparent)]
    BlockBuilderError(Arc<BlockBuilderError>),

BlockBuilderError has an Aborted variant. Can we use it and remove the ProposalError completely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants