Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): min compiler version for sierra gas type #2421

Draft
wants to merge 2 commits into
base: aviv/get_versioned_casm
Choose a base branch
from

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

AvivYossef-starkware commented Dec 3, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 3, 2024

@AvivYossef-starkware AvivYossef-starkware marked this pull request as draft December 3, 2024 10:10
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 2 times, most recently from 002ea4b to e0a4c01 Compare December 3, 2024 13:31
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_min_compiler_version_for_sierra_gas_type branch from 245624e to e5d5bca Compare December 3, 2024 13:31
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/blockifier/src/execution/contract_class.rs line 266 at r2 (raw file):

    /// Returns whether this contract should run using Cairo steps or Sierra gas.
    pub fn tracked_resource(&self, min_sierra_version: &SierraVersion) -> TrackedResource {
        if *min_sierra_version <= self.sierra_version {

This field is irrelevant now. You need to move fn tracked_resource to your new object - VersionedRunnableContractClass - it is the only one holding the actual Sierra version

Code quote:

self.sierra_version

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_min_compiler_version_for_sierra_gas_type branch from 4a0764f to 9325c6e Compare December 4, 2024 09:49
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants