refactor(blockifier): use get versioned contract class in py state reader #2614
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 10, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_casm
branch
from
0999dfe to
0637840
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_py_state_reader
branch
from
e372b53 to
40aecd0
Compare
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_casm
branch
from
0637840 to
447a92d
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_py_state_reader
branch
from
40aecd0 to
792e0ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## aviv/refactor_papyrus_rpc_get_contract_class #2614 +/- ##
================================================================================
- Coverage 47.99% 9.59% -38.40%
================================================================================
Files 185 139 -46
Lines 22963 18452 -4511
Branches 22963 18452 -4511
================================================================================
- Hits 11020 1771 -9249
- Misses 10843 16326 +5483
+ Partials 1100 355 -745 ☔ View full report in Codecov by Sentry. |
AvivYossef-starkware
force-pushed
the
aviv/get_versioned_casm
branch
from
447a92d to
ceffe13
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_py_state_reader
branch
from
792e0ff to
dbd8356
Compare
AvivYossef-starkware
changed the base branch from
aviv/get_versioned_casm
to
aviv/refactor_papyrus_rpc_get_contract_class
AvivYossef-starkware
force-pushed
the
aviv/refactor_papyrus_rpc_get_contract_class
branch
from
15f47f5 to
2ea9929
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_py_state_reader
branch
from
dbd8356 to
66ca4ac
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_papyrus_rpc_get_contract_class
branch
from
2ea9929 to
ea44d6f
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_py_state_reader
branch
from
66ca4ac to
294da4d
Compare
AvivYossef-starkware
requested review from
Yoni-Starkware and
dorimedini-starkware
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @Yoni-Starkware)
AvivYossef-starkware
force-pushed
the
aviv/refactor_papyrus_rpc_get_contract_class
branch
from
ea44d6f to
cc83787
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_py_state_reader
branch
from
294da4d to
f714969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.