Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(papyrus_storage): add sierra version to papyrus cache #2438

Open
wants to merge 1 commit into
base: aviv/get_versioned_casm
Choose a base branch
from
Open

feat(papyrus_storage): add sierra version to papyrus cache #2438

wants to merge 1 commit into from
+14 −13

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 3, 2024
Open
@AvivYossef-starkware Graphite App
Copy link
Contributor Author

AvivYossef-starkware commented Dec 3, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 3, 2024
Draft
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Artifacts upload workflows:

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 7f7dbe8 to 3de0987 Compare December 3, 2024 15:32
@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 3, 2024 15:33
@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 3, 2024
Merged
dorimedini-starkware
dorimedini-starkware approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)

a discussion (no related file):
General remark: I have a feeling the size of the sierra version cache should be identical to the size of the sierra contract cache -when will you want a version with the class / a class without the version?

Yoni-Starkware
Yoni-Starkware requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @TzahiTaub)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

General remark: I have a feeling the size of the sierra version cache should be identical to the size of the sierra contract cache -when will you want a version with the class / a class without the version?

Blocking - this PR is not relevant, we're going to have a cache for the Sierra classes.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 3de0987 to 5f9927f Compare December 4, 2024 09:35
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (aviv/get_versioned_casm@4471084). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/papyrus_state_reader/src/papyrus_state.rs 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##             aviv/get_versioned_casm    #2438   +/-   ##
==========================================================
  Coverage                           ?   60.25%           
==========================================================
  Files                              ?      180           
  Lines                              ?    20780           
  Branches                           ?    20780           
==========================================================
  Hits                               ?    12522           
  Misses                             ?     7426           
  Partials                           ?      832

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 2 times, most recently from f9fb3ea to 6475cf1 Compare December 4, 2024 09:49
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 5f9927f to f0084d8 Compare December 4, 2024 09:50
dorimedini-starkware
dorimedini-starkware approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from f0084d8 to 2779f87 Compare December 4, 2024 10:40
dorimedini-starkware
dorimedini-starkware requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

This was referenced Dec 5, 2024
Merged
Merged
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch 2 times, most recently from 428e056 to b5d8874 Compare December 5, 2024 10:41
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 9c10db4 to 3f30869 Compare December 8, 2024 09:37
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 2 times, most recently from ade6fb9 to d2f5604 Compare December 8, 2024 11:07
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 3f30869 to 9c1e654 Compare December 8, 2024 11:07
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 9c1e654 to 4068cd0 Compare December 8, 2024 11:34
dorimedini-starkware
dorimedini-starkware approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 4068cd0 to f1edf4a Compare December 9, 2024 11:16
dorimedini-starkware
dorimedini-starkware approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from f1edf4a to a4c372e Compare December 10, 2024 07:36
dorimedini-starkware
dorimedini-starkware approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 10, 2024
Open
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from a4c372e to fd89b79 Compare December 10, 2024 08:24
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from fd89b79 to d7a28ec Compare December 10, 2024 08:28
dorimedini-starkware
dorimedini-starkware approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r11, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from d7a28ec to b049066 Compare December 10, 2024 10:56
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from b049066 to a59ff17 Compare December 10, 2024 10:58
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from a59ff17 to 4215de2 Compare December 10, 2024 14:43
@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 10, 2024
Open
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 4215de2 to d076f8e Compare December 12, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@TzahiTaub TzahiTaub Awaiting requested review from TzahiTaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AvivYossef-starkware @reviewable-StarkWare @dorimedini-starkware @Yoni-Starkware