Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-463] fixes to levels with costs #677

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

ncontinanza
Copy link
Contributor

@ncontinanza ncontinanza commented Jun 4, 2024

Motivation

Part of lambdaclass/afk_gacha_game#463

Summary of changes

  • Preload the attempt_cost currency of a level before sending the campaign to the client.
  • Fix the index of the slot of the dungeon levels units.
  • Add max_units of a level to the proto message

How to test it?

Start the client with this branch: lambdaclass/afk_gacha_game#477
You should be able to spend up to 5 Supplies playing dungeon levels, and see the cost of each level in the line up scene.
You shouldn't be able to play a dungeon level if you exceed the units limit.

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@ncontinanza ncontinanza marked this pull request as ready for review June 4, 2024 18:05
@lotuuu lotuuu added the autobattler AFK Gacha Autobattler game label Jun 4, 2024
@ncontinanza ncontinanza changed the title [GH-463] fix to levels with costs [GH-463] fixes to levels with costs Jun 4, 2024
priv/repo/seeds.exs Outdated Show resolved Hide resolved
@lotuuu lotuuu mentioned this pull request Jun 5, 2024
Copy link
Contributor

@agustinesco agustinesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agustinesco agustinesco merged commit e080f4e into main Jun 5, 2024
1 check passed
@agustinesco agustinesco deleted the gh-463-fix-to-levels-with-costs branch June 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobattler AFK Gacha Autobattler game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants