Fix failing dungeon test #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A failing test was introduced by #658. The reason why this escaped the CI is that the branch was not up to date with main when the passing CI was ran. To avoid this issue in the future, we could implement a restriction in the repo where only up-to-date with
mainbranches can be merged. We have this setting enabled in the AFK Gacha Game repo.In main, max_units restrictions had been introduced for levels, together with the seeds that set that field to 1 in the first level of the dungeon. This is what was missing on the wrong-succesful CI.
Summary of changes
How to test it?
Run
mix tests