-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-463] Levels with cost #477
Draft
ncontinanza
wants to merge
12
commits into
gh-411-dungeon-supercampaign-scene
Choose a base branch
from
gh-463-levels-with-cost
base: gh-411-dungeon-supercampaign-scene
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[GH-463] Levels with cost #477
ncontinanza
wants to merge
12
commits into
gh-411-dungeon-supercampaign-scene
from
gh-463-levels-with-cost
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aclass/afk_gacha_game into gh-463-levels-with-cost
ncontinanza
changed the base branch from
main
to
gh-411-dungeon-supercampaign-scene
June 3, 2024 15:42
4 tasks
ncontinanza
requested review from
AminArria,
manucamejo,
tvillegas98,
martinacantaro,
mgrunwaldt,
saugon,
marco-paulucci,
agustinesco,
tkz00,
Nico-Sanchez,
lotuuu,
AngieDutra and
alfopisano
as code owners
June 4, 2024 18:05
ncontinanza
added
the
Waiting on PR
Use this tag to alert reviewers that this PR shouldn't be merged until another one is merged first
label
Jun 4, 2024
…aclass/afk_gacha_game into gh-463-levels-with-cost
Also, when I win a dungeon level the app crashes because it does not know the currency rewards
|
Some of these errors might be from #478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Waiting on PR
Use this tag to alert reviewers that this PR shouldn't be merged until another one is merged first
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463
Motivation
We need to adapt the client to the levels having a cost in the Dungeon supercampaign.
Summary of changes
How has this been tested?
Disclaimer: In order to win the first dungeon levels and test some of the available levels in the campaign, you may need to get some upgrades for your units. Follow these steps to do so:
user = Champions.Users.get_user_by_username(your_username)
.GameBackend.Users.Currencies.add_currency_by_name_and_game(user.id, "Pearls", 2, 1000)
GameBackend.Repo.all(GameBackend.Users.Upgrade)
Champions.Users.purchase_dungeon_upgrade(user.id, upgrade1_id)
Champions.Users.purchase_dungeon_upgrade(user.id, upgrade2_id)
With this, you should be able to play and win the first Dungeon levels.
Test additions / changes
List tests added/updated.
Checklist