-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented #141 #161
implemented #141 #161
Conversation
usage in config: "weapons": "Vandal, Phantom, ..." https://legende.cc/ss/9670865ba4.png
I decided to remove the redundent "Vandal" or "Phantom" at the end of the Skin name, to fit more weapons. |
Otherwhise you could think about cutting it even further- |
made hiding the weapon suffix optional via the config
Putting this on hold whilst the team discuss this. There are a couple changes made here which I'm not sure about. Firstly the matter of config, we need to make sure users' inputs for the weapon(s) is a smooth process. Secondly, I'm hesistant to employ abbreviations, it is not something I want to put pressure on us to maintain nor do I want to push us for more often releases just to update this list; I'm sure an argument could be made for the app to request a list of abbreviations from our repo instead of us re-releasing copies of the app, but that's not something I feel particularly strong for either. This will be a good PR, we just need to consider other approaches for implementing this. |
"hide_skin_weapon_suffix": True, | ||
"skin_abbreviations": { | ||
"status": True, | ||
"abbreviations": { | ||
"Gravitational Uranium Neuroblaster": "GUN", | ||
"Radiant Entertainment System": "RES", | ||
"VALORANT GO! Vol. 1": "V. G. Vol. 1", | ||
"VALORANT GO! Vol. 2": "V. G. Vol. 2", | ||
"Radiant Crisis 001": "RC 001", | ||
"Sentinels of Light": "SoL", | ||
"Prelude to Chaos": "PtC", | ||
"Winterwunderland": "Winter", | ||
"Kohaku & Matsuba": "K&M", | ||
"Gaia's Vengeance": "Gaia" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #161 (comment)
I believe, that just seperating them with a comma is quite a smooth process, especially if there are 2 weapons defaulted.
I compleatly understand your position here, I just thought that "Gravitational Uranium Neuroblaster Operator" is quite a long name for a columne, which is why i would shorten some, or at least remove the weapon tag "Operator" at the end.
I appreciate to hear that :D |
I personally disagree with this. Unofficial abbreviations would be very confusing for a lot of people. |
I somewhat agree with that statement, but like I said: "Gravitational Uranium Neuroblaster Operator" is quite long for a columne and normally takes up multiple rows to be displayed. |
usage in config:
"weapons": "Vandal, Phantom, ..."