Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented #141 #161

Closed
wants to merge 3 commits into from
Closed

implemented #141 #161

wants to merge 3 commits into from

Conversation

JanEickholt
Copy link

usage in config:
"weapons": "Vandal, Phantom, ..."
cmd_9NCHKzXrke

usage in config:
"weapons": "Vandal, Phantom, ..."
https://legende.cc/ss/9670865ba4.png
@JanEickholt
Copy link
Author

I decided to remove the redundent "Vandal" or "Phantom" at the end of the Skin name, to fit more weapons.
If you want to remove this on a final release you can change line 50 in Loadouts.py to:
weaponLists[players[player]["Subject"]][weapon["displayName"]] = (color(skin["displayName"], fore=rgb_color))

@JanEickholt
Copy link
Author

Otherwhise you could think about cutting it even further-
Sentinels of Light = SOL
Gravitational Uranium Neuroblaster = GUN
Radiant Entertainment System = RES

made hiding the weapon suffix optional via the config
@zayKenyon zayKenyon added question Further information is requested feature request semver:minor labels Jul 31, 2023
@zayKenyon zayKenyon added this to the 2.7 milestone Jul 31, 2023
@zayKenyon
Copy link
Owner

Putting this on hold whilst the team discuss this. There are a couple changes made here which I'm not sure about.

Firstly the matter of config, we need to make sure users' inputs for the weapon(s) is a smooth process. Secondly, I'm hesistant to employ abbreviations, it is not something I want to put pressure on us to maintain nor do I want to push us for more often releases just to update this list; I'm sure an argument could be made for the app to request a list of abbreviations from our repo instead of us re-releasing copies of the app, but that's not something I feel particularly strong for either.

This will be a good PR, we just need to consider other approaches for implementing this.

@zayKenyon zayKenyon marked this pull request as draft July 31, 2023 19:04
Comment on lines +159 to +174
"hide_skin_weapon_suffix": True,
"skin_abbreviations": {
"status": True,
"abbreviations": {
"Gravitational Uranium Neuroblaster": "GUN",
"Radiant Entertainment System": "RES",
"VALORANT GO! Vol. 1": "V. G. Vol. 1",
"VALORANT GO! Vol. 2": "V. G. Vol. 2",
"Radiant Crisis 001": "RC 001",
"Sentinels of Light": "SoL",
"Prelude to Chaos": "PtC",
"Winterwunderland": "Winter",
"Kohaku & Matsuba": "K&M",
"Gaia's Vengeance": "Gaia"
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanEickholt
Copy link
Author

JanEickholt commented Jul 31, 2023

Firstly the matter of config, we need to make sure users' inputs for the weapon(s) is a smooth process.

I believe, that just seperating them with a comma is quite a smooth process, especially if there are 2 weapons defaulted.

Secondly, I'm hesistant to employ abbreviations

I compleatly understand your position here, I just thought that "Gravitational Uranium Neuroblaster Operator" is quite a long name for a columne, which is why i would shorten some, or at least remove the weapon tag "Operator" at the end.

This will be a good PR, we just need to consider other approaches for implementing this.

I appreciate to hear that :D

@ovosimpatico
Copy link

Otherwhise you could think about cutting it even further- Sentinels of Light = SOL Gravitational Uranium Neuroblaster = GUN Radiant Entertainment System = RES

I personally disagree with this. Unofficial abbreviations would be very confusing for a lot of people.

@JanEickholt
Copy link
Author

I personally disagree with this. Unofficial abbreviations would be very confusing for a lot of people.

I somewhat agree with that statement, but like I said: "Gravitational Uranium Neuroblaster Operator" is quite long for a columne and normally takes up multiple rows to be displayed.
I sadly don't know any official abbreviations, which is why i just chose some "random" - Prelude to Chaos is normally just called "Chaos Vandal"... not PtC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request question Further information is requested semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Show in the console two or more weapons skins using the config
3 participants