-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show in the console two or more weapons skins using the config #141 #164
Conversation
usage in config: "weapons": "Vandal, Phantom, ..." https://legende.cc/ss/9670865ba4.png
made hiding the weapon suffix optional via the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the config onboarding (when you run the app with the --config
flag), users can input a weapon via InquirerPy, could you change this so they can make 2 inputs?
src/constants.py
Outdated
"skin_abbreviations": { | ||
"status": True, | ||
"abbreviations": { | ||
"Gravitational Uranium Neuroblaster": "GUN", | ||
"Radiant Entertainment System": "RES", | ||
"VALORANT GO! Vol. 1": "V. G. Vol. 1", | ||
"VALORANT GO! Vol. 2": "V. G. Vol. 2", | ||
"Radiant Crisis 001": "RC 001", | ||
"Sentinels of Light": "SoL", | ||
"Prelude to Chaos": "PtC", | ||
"Winterwunderland": "Winter", | ||
"Kohaku & Matsuba": "K&M", | ||
"Gaia's Vengeance": "Gaia" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously discussed: here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add Tethered Realms, Nunca Olvidados, Radiant Crisis 001, Protocol 781-A, Divine Swine, Lycan's Bane, Coalition Cobra, Task Force 809, Piedra del Sol, Premiere Collision, Starlit Odyssey.
There are many long skin names making all of them short will make it confusing but we need to have a good system for this other wise there wont be space left in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add Tethered Realms, Nunca Olvidados, Radiant Crisis 001, Protocol 781-A, Divine Swine, Lycan's Bane, Coalition Cobra, Task Force 809, Piedra del Sol, Premiere Collision, Starlit Odyssey.
I added all of them, that are longer than 10 characters
There are many long skin names making all of them short will make it confusing
I understand your point, but I would still appreciate suggestions on making it possible
added all weapon skins to the abbreviations list, that are longer than 10 characters (suggestions wanted)
I am unsure about the elegance of the code, but you can add multiple weapons now |
just #161, but in a new branch now