[dotnet-linker] Improve error reporting by not forgetting about origi…

…nal exceptions. (#21464) This way we report the stack trace of the original exception in build logs.
xamarin · Oct 19, 2024 · a890a0e · a890a0e
1 parent cbc5746
commit a890a0e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tools/dotnet-linker/Steps/ConfigurationAwareStep.cs b/tools/dotnet-linker/Steps/ConfigurationAwareStep.cs
@@ -106,17 +106,17 @@ bool CollectProductExceptions (Exception e, [NotNullWhen (true)] out List<Produc
 
 		protected virtual Exception [] Fail (AssemblyDefinition assembly, Exception e)
 		{
-			return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode, Errors.MX_ConfigurationAwareStepWithAssembly, Name, assembly?.FullName, e.Message));
+			return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode, e, Errors.MX_ConfigurationAwareStepWithAssembly, Name, assembly?.FullName, e.Message));
 		}
 
 		protected virtual Exception [] Fail (Exception e)
 		{
-			return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 1, Errors.MX_ConfigurationAwareStep, Name, e.Message));
+			return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 1, e, Errors.MX_ConfigurationAwareStep, Name, e.Message));
 		}
 
 		protected virtual Exception [] FailEnd (Exception e)
 		{
-			return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 2, Errors.MX_ConfigurationAwareStep, Name, e.Message));
+			return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 2, e, Errors.MX_ConfigurationAwareStep, Name, e.Message));
 		}
 
 		Exception [] CollectExceptions (Exception e, Func<ProductException> createException)