Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-11901] Add rate limiting for any endpoints which hash a password #4350

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

[WPB-11901] Add rate limiting for any endpoints which hash a password #4350

wants to merge 4 commits into from

Commits on Nov 28, 2024

  1. Define two rate limit zones at the nginx level 

    One limits per IP address and the other limits per ZUser
    @pcapriotti @mdimjasevic
    pcapriotti authored and mdimjasevic committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    41660ea View commit details
    Browse the repository at this point in the history

  2. Rate limit requests to select endpoints 

    All the endpoints that perform password hashing are rate limited with
one of the introduced rate limit zones. The endpoints were identified by
searching for every endpoint handler that has the 'HashPassword' effect
in its constraints.
    @mdimjasevic
    mdimjasevic committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    058e9ef View commit details
    Browse the repository at this point in the history

  3. WIP

    @mdimjasevic
    mdimjasevic committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    7fab331 View commit details
    Browse the repository at this point in the history

  4. WIP: Put all password hashing ops in one place 

    Once they are all in that effect, we can start asking for either the user ID or
the IP address and use that to rate limit.
    @akshaymankar
    akshaymankar committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    2641e99 View commit details
    Browse the repository at this point in the history