[WPB-11901] Add rate limiting for any endpoints which hash a password #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/security
zebot
added
the
ok-to-test
One limits per IP address and the other limits per ZUser
All the endpoints that perform password hashing are rate limited with one of the introduced rate limit zones. The endpoints were identified by searching for every endpoint handler that has the 'HashPassword' effect in its constraints.
mdimjasevic
force-pushed
the
hash-rate-limiting
branch
from
4610d39
to
058e9ef
Compare
Once they are all in that effect, we can start asking for either the user ID or the IP address and use that to rate limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by https://wearezeta.atlassian.net/browse/WPB-11901
Checklist
changelog.d