Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/checkinstall #8

Open
wants to merge 3 commits into
base: x-series
Choose a base branch
from
Open

Feature/checkinstall #8

wants to merge 3 commits into from

Conversation

nyxrobotics
Copy link

Summary

Fix #7

Detail

  • Add sudo ./waf checkinstall command for Debian/Ubuntu.
  • Update README.md

@nyxrobotics nyxrobotics requested a review from ssr-yuki December 8, 2021 05:24
jsupratman13
jsupratman13 requested changes Dec 13, 2021
View reviewed changes
Copy link

@jsupratman13 jsupratman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実機で問題がなく動けました

README.md Show resolved Hide resolved
ssr-yuki
ssr-yuki suggested changes Dec 13, 2021
View reviewed changes
Copy link

@ssr-yuki ssr-yuki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change sets the package name to dynamixel-demos but this is just name of a sample binary. In fact, this is LIBRARY named 'libdynamixel'. Using APPNAME as a package name is not appropriate.

@nyxrobotics
Copy link
Author

APPNAME was not used in libdynamixel.
There is no need to keep the name dynamixel-demos, so APPNAME was changed to libdynamixel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssr-yuki ssr-yuki Awaiting requested review from ssr-yuki

@jsupratman13 jsupratman13 Awaiting requested review from jsupratman13

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

依存関係解決・Checkinstall対応
3 participants
@nyxrobotics @jsupratman13 @ssr-yuki