feat: added custom condition to the aria-label user button #6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
Wagner3UB
requested review from
pnicolli,
JeffersonBledsoe,
ichim-david and
SaraBianchi
JeffersonBledsoe
requested changes
Sep 27, 2024
ichim-david
reviewed
Oct 1, 2024
stevepiercy
requested changes
Oct 1, 2024
stevepiercy
reviewed
Oct 1, 2024
Wagner3UB
requested review from
JeffersonBledsoe,
stevepiercy and
ichim-david
stevepiercy
requested changes
Oct 14, 2024
stevepiercy
approved these changes
Oct 14, 2024
JeffersonBledsoe
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Looks good!
I'm going to re-run the readme link check, as it's a little flakey and failed on https://www.ueu.eus/ , even though the site is able to be accessed
|
@stevepiercy Any idea what's up with the failing ReadTheDocs CI step? |
|
@sneridagh I'd ignore it as it is for the deleted RTD project, and was probably due to our fiddling around with it, based on the timing. |
|
@Wagner3UB Can you change the label to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a condition to set the aria-label to differentiate the "regular users" from the admin users.
The condition is the same one used inside the 'PersonalTools' component, which opens after the user button is clicked.
Issue with discussion:
#5119