Add compatibility with php8.2 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nick-zh, please review. |
nick-zh
requested changes
Oct 9, 2023
nick-zh
reviewed
Oct 9, 2023
misterxan
force-pushed
the
add-php82-support
branch
2 times, most recently
from
b81976a to
26b8718
Compare
Also fix some warnings after running phpunit/php-cs-fixer/phpstan
misterxan
force-pushed
the
add-php82-support
branch
from
26b8718 to
49d6134
Compare
|
@misterxan thx a lot again, released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/Optimizer/FullNameOptimizer.phpin theremoveNamespaceFromStringmethod, assuming that$currentNameSpacePathswould, in one way or another, have a larger dimension than$dataNameSpacePaths. Previously, it was the other way around, which caused a warning with an undefined key 2 when I ran tests.The question is whether to keep
$method->setAccessible(true);in tests since it has no effect starting from 8.1. However, compatibility with 8.0 will be lost, so I think it's worth not removing it.