Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Remove clevis overrides for OKD #1675

Merged

Conversation

Prashanth684
Copy link
Contributor

@Prashanth684 Prashanth684 commented Dec 9, 2024

Due to #1630, we had to pin clevis to an older version. This was fixed in clevis-21-203.el9, so removing it.

Due to openshift#1630, we had to pin clevis
to an older version. This was fixed in clevis-21-203.el9, so removing
this
@openshift-ci openshift-ci bot requested review from cgwalters and jmarrero December 9, 2024 15:24
@dustymabe dustymabe changed the title Remove clevis overrides for OKD NO-JIRA: Remove clevis overrides for OKD Dec 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 9, 2024
@openshift-ci-robot
Copy link

@Prashanth684: This pull request explicitly references no jira issue.

In response to this:

Due to #1630, we had to pin clevis to an older version. This was fixed in clevis-21-203.el9, so removing it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684 Prashanth684 added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0bbe155 into openshift:master Dec 9, 2024
11 checks passed
@Prashanth684
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@Prashanth684: new pull request created: #1677

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants