Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17]:NO-JIRA: Remove clevis overrides for OKD #1681

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[release-4.17]:NO-JIRA: Remove clevis overrides for OKD #1681

merged 1 commit into from
Dec 10, 2024

Conversation

Prashanth684
Copy link
Contributor

Manual cherry-pick of #1675 due to merge conflict

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 9, 2024
@openshift-ci-robot
Copy link

@Prashanth684: This pull request explicitly references no jira issue.

In response to this:

Manual cherry-pick of #1675 due to merge conflict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from HuijingHei and prestist December 9, 2024 21:41
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684
Copy link
Contributor Author

/cc @dustymabe

@openshift-ci openshift-ci bot requested a review from dustymabe December 10, 2024 00:42
@Prashanth684 Prashanth684 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Dec 10, 2024
HuijingHei
HuijingHei approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@HuijingHei
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prashanth684 Prashanth684 added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 434f71a into openshift:release-4.17 Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuijingHei HuijingHei HuijingHei approved these changes

@prestist prestist Awaiting requested review from prestist

@dustymabe dustymabe Awaiting requested review from dustymabe

Assignees

@HuijingHei HuijingHei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prashanth684 @openshift-ci-robot @HuijingHei