Docs: added copy button to non-inline code snippets #29700
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Oct 21, 2024
| width: 24px; | ||
| height: 24px; | ||
| background-color: transparent; | ||
| background-image: url('/files/ic_copy_grey_24dp.svg'); |
There was a problem hiding this comment.
Can you write these URLs like so:
background-image: url('../files/ic_copy_grey_24dp.svg');
That makes them more compatible with different hosting setups like githack. Check out the 404 in:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
copy buttonto non-inline code snippets in theDocspages, so that viewers can copy snippets easier as they go through the documentationsvgicons (copyandtickicons) that are from Iconify, in which both are allowed for commercial use and no attribution required, so it should be good to usetickicon to alert users on copy successful state so no localization is requiredFeature Screenshots
Light Mode:
Dark Mode:
Video Demo:
https://drive.google.com/file/d/1fMJ6SR6oGHHYmZ0OdtRYgRsNG2M0k9lu/view?usp=sharing