WIP TypeScript code refactor #1128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldy505
reviewed
Apr 14, 2023
|
@aldy505 I think it would be better to review the seprated pr instead this big one, so we don't need to review same code twice |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
trim21
changed the title
trim21
force-pushed
the
refactor-client
branch
2 times, most recently
from
ff18ab5 to
0715ac5
Compare
fflorent
reviewed
Jul 14, 2023
fflorent
pushed a commit
to fflorent/minio-js
that referenced
this pull request
Jul 15, 2023
Closed
fflorent
added a commit
to fflorent/minio-js
that referenced
this pull request
Jul 18, 2023
fflorent
pushed a commit
to fflorent/minio-js
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1120 #1119
and close #1106
please don't review the details of this PR, it for staging the migration I have made.
all files have aleady been re-written in TS (with minor
any)just wait previous PR to me merged, the we can start to split this PR into smaller patch to seprated PR for code review.
We should migrate base files first, ts file should not import js file.
and minio.js (the
Clientclass) is very large so we should create a typed base class and migrate methods progressively