Refactor ts types #1186
Closed
Refactor ts types #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
reviewed
Jul 16, 2023
trim21
reviewed
Jul 16, 2023
trim21
reviewed
Jul 16, 2023
fflorent
force-pushed
the
refactor-ts-types
branch
from
a21c956 to
40be1c9
Compare
|
Hi @trim21 @prakashsvmx @kaankabalak @harshavardhana can we prioritize this first? Or is there any other stuff that's blocking this PR to be merged (other than code reviews)? |
|
Should I close this issue? |
|
Yes. @fflorent . thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates type definitions, mostly based on file
src/internal/types.tsof #1128.