-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: add prettier, lint-staged, husky and eslint rules #1120
Conversation
I've seen the code changes. #1119 should be merged first in order for this one to continue. |
The patch of this PR is inclued in #1119, if #1119 is merged then this PR could be close. As I said in #1119
personally I hope to merge this PR first then I rebase #1119 and then review/merge it |
Thank you @trim21 . I ran tests locally and looks good. 👍 suggestion : we could exclude CI config files from formatting |
Just add ci files to prettierignore and split lint/build workflow to a seprated workflow file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
add eslint rule |
@kannappanr @harshavardhana could you please review this pr? We are trying to migrate source to TypeScript and want to add a formatter first for easier code review, this pr add formatter only and no code are changed, just reformatted |
resolve conflict |
@kannappanr @harshavardhana can you take a look? |
🤔any news on this? |
merge current master branch and resolve conflict |
rollup plugins are added unintendedly |
@harshavardhana there is no more feature/fix PR, would you mind review this PR now? |
merge current master branch and resolve conflict |
@prakashsvmx for fast review, this it what changed since your last approval I hope we can merge this soon so I don't need to keep merging branch again and again... meanwhile GitHub dismisses the approval, take it forever to get all reviewers' approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran Tests Locally. All tests passing. 👍
style only changes of PR #1119
It doesn't change any code, just re-formatting, only code outside
examples/
andsrc/
are manually changedyou can verify it by these steps:
eslintrc is copied from #1114 and prettier/husky/lint-staged is from #1109 (comment)
add eslint plugin
eslint-plugin-simple-import-sort
(quotes of previous source code are mixed, so prettier config singleQuote true of false doesn't make much difference...)