generated from linkml/linkml-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make schema-derived JSON and YAML files downloadable via docs website #2302
Draft
eecavanna
wants to merge
5
commits into
main
Choose a base branch
from
1960-omit-derived-files-from-repo-generate-them-locally-instead
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Make schema-derived JSON and YAML files downloadable via docs website #2302
eecavanna
wants to merge
5
commits into
main
from
1960-omit-derived-files-from-repo-generate-them-locally-instead
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbomam and I discussed this PR today. Here's my public "notes" list, after having that discussion:
Once I'm ready for @turbomam to take another look at this PR branch, I'll tell him that. It's still in a draft state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I made a proof of concept of making the schema-derived YAML and JSON files be accessible via the GitHub Pages-hosted documentation website instead of via the Git repository, itself. They would be generated by a GitHub Actions workflow based upon the source files in the Git repository, so they'd always be consistent with those source files (whereas, today, keeping them consistent is a manual process).
Here's a screenshot of a barebones web page that has links to each file. This is a proof of concept, not necessarily the most user friendly presentation of these files. We can iterate on this as we did when introducing a refscan-generated diagram into the documentation a few weeks ago. For example, we could display the actual contents of each file within an in-page code viewer widget, such as the one provided by CodeMirror.
When I click on any of the links, my web browser either displays its contents (if it's a JSON file) or prompts me to choose where I want it to be downloaded to (if it's a YAML file). This behavior is web browser-dependent, but we (the creators of the web page) can do things to tell the web browser what we'd prefer it do.
Each of the files can be downloaded via
curl
, as shown here: