Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-486] Adapt campaigns scene to new config data #488

Merged
merged 4 commits into from
Jun 12, 2024
Merged

[GH-486] Adapt campaigns scene to new config data #488

merged 4 commits into from
Jun 12, 2024

Conversation

lotuuu
Copy link
Collaborator

@lotuuu lotuuu commented Jun 10, 2024 •
edited
Loading

Closes #486

Motivation

Adds new campaign3 and campaign4 prefabs.

Summary of changes

  • Add campaign3 prefab
  • Add campaign4 prefab
  • Fix case where a level ends but there is no next_level

How has this been tested?

Go through all levels, everything should work.

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I self-reviewed the changes on GitHub, line by line.
  • Tests have been added/updated.
  • This change requires new documentation.
    • Documentation has been added/updated.
  • I have tested the changes in another devices.
    • Tested in iOS.
    • Tested in Android.

@lotuuu lotuuu linked an issue Jun 10, 2024 that may be closed by this pull request
Adapt campaigns scene to new config data #486
Closed
@lotuuu lotuuu marked this pull request as ready for review June 11, 2024 13:42
@lotuuu lotuuu self-assigned this Jun 11, 2024
ncontinanza
ncontinanza approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@ncontinanza ncontinanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tkz00

This comment was marked as resolved.

Sign in to view

tkz00
tkz00 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@tkz00 tkz00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-06-12.at.3.41.08.PM.mov

This is a know issue and it should not happen, the issue lies actually in the backend.

@tkz00 tkz00 merged commit bb8af6c into main Jun 12, 2024
1 check passed
@tkz00 tkz00 deleted the 486-adapt-campaigns-scene-to-new-config-data branch June 12, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkz00 tkz00 tkz00 approved these changes

@ncontinanza ncontinanza ncontinanza approved these changes

@AminArria AminArria Awaiting requested review from AminArria AminArria is a code owner

@manucamejo manucamejo Awaiting requested review from manucamejo manucamejo is a code owner

@tvillegas98 tvillegas98 Awaiting requested review from tvillegas98 tvillegas98 is a code owner

@martinacantaro martinacantaro Awaiting requested review from martinacantaro martinacantaro is a code owner

@mgrunwaldt mgrunwaldt Awaiting requested review from mgrunwaldt

@saugon saugon Awaiting requested review from saugon saugon is a code owner

@marco-paulucci marco-paulucci Awaiting requested review from marco-paulucci marco-paulucci is a code owner

@agustinesco agustinesco Awaiting requested review from agustinesco agustinesco is a code owner

@Nico-Sanchez Nico-Sanchez Awaiting requested review from Nico-Sanchez Nico-Sanchez is a code owner

@AngieDutra AngieDutra Awaiting requested review from AngieDutra AngieDutra is a code owner

@alfopisano alfopisano Awaiting requested review from alfopisano alfopisano is a code owner

Assignees

@lotuuu lotuuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt campaigns scene to new config data
3 participants
@lotuuu @ncontinanza @tkz00