Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directory and path cleanup; see description #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awardell
Copy link

Hi kyperbelt. I tried using your plugin, and when I moved the compiled program to a subdirectory it broke. I've made the following fixes so that compiled yarn programs can correctly be loaded from anywhere and also so that the plugin doesn't need to dump as much into the root res:// folder:

  • Moved example files into res://gdyarn/ subdirectory.
  • Fixed broken path formatting in program_utils.gd
  • Moved .tracked_yarn_files to res://addons/gdyarn/ and updated path in yarn_importer.gd

Thank you for creating and maintaining this plugin!

Moved example files into res://gdyarn/ subdirectory.
Fixed broken path formatting in program_utils.gd
Moved .tracked_yarn_files to res://addons/gdyarn/ and updated path in yarn_importer.gd
@kyperbelt
Copy link
Owner

Hey awardell,

Sorry for the late reply. I haven't had much time to work on this project as of late but will try to do so within the next week or two. I will take a look at the issues you were having to see if I could replicate them.

Was the issue caused when you would compile a program and then move the compiled program into a different folder WITH the yarn file?

If you could give me a step-by-step on how to recreate the issue it would help me better assess the changes.

  • kyperbelt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants