Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint and stricter TypeScript rules for jspsych package #3389

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add eslint and stricter TypeScript rules for jspsych package #3389

wants to merge 11 commits into from

Commits on Aug 29, 2024

  1. add eslint for jspsych package

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c039e14 View commit details
    Browse the repository at this point in the history

  2. add lint command to jspsych package scripts

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    67b1f9b View commit details
    Browse the repository at this point in the history

  3. allow unused vars starting with _ in eslint config

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7aebc69 View commit details
    Browse the repository at this point in the history

  4. remove or underscore unused variables

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c9c3588 View commit details
    Browse the repository at this point in the history

  5. set noUnusedLocals to true in jspsych tsconfig

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d66d0dc View commit details
    Browse the repository at this point in the history

  6. fix noUnusedLocals problems in jspsych package

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8f2ffd4 View commit details
    Browse the repository at this point in the history

  7. fix prefer-const and no-var linting issues

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ad92703 View commit details
    Browse the repository at this point in the history

  8. replace Object.prototype.hasOwnProperty with Object.hasOwn

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5eaff6c View commit details
    Browse the repository at this point in the history

  9. fix @typescript-eslint/ban-ts-comment issues

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    148409b View commit details
    Browse the repository at this point in the history

  10. fix no-useless-escape problem

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dfe8aaa View commit details
    Browse the repository at this point in the history

  11. add tsc --noEmit to linting command in jspsych package

    @joshunrau
    joshunrau committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9973190 View commit details
    Browse the repository at this point in the history