Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint and stricter TypeScript rules for jspsych package #3389

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

joshunrau
Copy link
Contributor

I am planning to add the option to use camel case variables to the jspsych (see issue #3386). To make sure this doesn't break any existing functionality, I think it would be a good idea to enable TypeScript strict mode (I also see this is something you want on a "lucky day"). Well, it is a lucky day!

I propose to do this in stages, each adding one of the strict rules (until finally strictNullChecks, which is the really difficult one here). I also added eslint (only for the jspsych package) to help with some additional best practices checking.

This PR makes changes that bring the existing code into compliance with the standard TypeScript linting rules and noUnusedLocales TypeScript rules.

I also removed the AudioContext hack for Safari, as it looks like AudioContext has been supported in Safari for a number of years now. If this is not okay, let me know I can add it back.

Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: 9973190

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jodeleeuw jodeleeuw requested a review from bjoluc August 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant