Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O_EMOJI: Use a bigger variety of emoji #1950

Merged
merged 4 commits into from
Nov 8, 2024
Merged

O_EMOJI: Use a bigger variety of emoji #1950

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ef5d12
O_EMOJI: Use a bigger variety of emoji
dkabus Nov 6, 2024
e4ea1fd
O_ICONS: Use generic emoji for FSHARP
dkabus Nov 6, 2024
c299fe8
O_ICONS: Use generic emoji for GO
dkabus Nov 6, 2024
d6fe034
revert vim emoji
N-R-K Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions src/icons.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
#define ICON_BRIEFCASE ICON_STR(FA_BRIEFCASE, "σ°ƒ–", "πŸ’Ό")
#define ICON_C ICON_STR(MFIZZ_C, "", "πŸ‡¨ ")
#define ICON_CHANGELOG ICON_STR(FA_HISTORY, "σ°‹š", "πŸ”Ί")
#define ICON_CHESS ICON_STR("", "σ°„Ί", "")
#define ICON_CHESS ICON_STR("", "σ°„Ί", "β™ŸοΈ ")
N-R-K marked this conversation as resolved.
Show resolved Hide resolved
#define ICON_CLOJURE ICON_STR(MFIZZ_CLOJURE, "ξͺ", "")
#define ICON_CONFIGURE ICON_STR(FILE_CONFIG, "", "πŸ”§")
#define ICON_CPLUSPLUS ICON_STR(MFIZZ_CPLUSPLUS, "", ICON_C)
Expand All @@ -68,64 +68,64 @@
#define ICON_DOWNLOADS ICON_STR(FA_DOWNLOAD, "σ°ƒ˜", "πŸ“₯")
#define ICON_ELIXIR ICON_STR(MFIZZ_ELIXIR, "", "πŸ’§")
#define ICON_ENCRYPT ICON_STR("", "σ°Œ†", "πŸ”’")
#define ICON_FSHARP ICON_STR(DEV_FSHARP, "", "")
#define ICON_FONT ICON_STR(FILE_FONT, "ο€±", "")
#define ICON_FSHARP ICON_STR(DEV_FSHARP, "", "πŸ”·")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have a generic source code icon instead of using emojies which are vaguely similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. I've adressed this in commit e4ea1fd

#define ICON_FONT ICON_STR(FILE_FONT, "ο€±", "πŸ”€")
#define ICON_GIT ICON_STR(FA_GIT, "ξ—»", "🌱")
#define ICON_HASKELL ICON_STR("", "", "")
#define ICON_HTML ICON_STR(FA_FILE_CODE_O, "󰌝", "")
#define ICON_HTML ICON_STR(FA_FILE_CODE_O, "󰌝", "🌍")
#define ICON_JAVA ICON_STR(MFIZZ_JAVA, "", "β˜•")
#define ICON_JAVASCRIPT ICON_STR(FA_FILE_CODE_O, "󰌞", "")
#define ICON_JAVASCRIPT ICON_STR(FA_FILE_CODE_O, "󰌞", ICON_SCRIPT)
#define ICON_LICENSE ICON_STR(FA_COPYRIGHT, "σ°ˆ™", "βš–οΈ ")
#define ICON_LINUX ICON_STR(FA_LINUX, "󰌽", "🐧")
#define ICON_MAKEFILE ICON_STR(FILE_CMAKE, "󰆍", "πŸ›  ")
#define ICON_MANUAL ICON_STR(FILE_MANPAGE, "󱓷", "❓")
#define ICON_MS_EXCEL ICON_STR(FILE_EXCEL, "σ°ˆ›", ICON_WORDDOC)
#define ICON_MS_EXCEL ICON_STR(FILE_EXCEL, "σ°ˆ›", "πŸ“—")
#define ICON_MUSIC ICON_STR(FA_MUSIC, "󱍙", "🎧")
#define ICON_MUSICFILE ICON_STR(FA_FILE_AUDIO_O, "󰎈", ICON_MUSIC)
#define ICON_MUSICFILE ICON_STR(FA_FILE_AUDIO_O, "󰎈", "🎡")
#define ICON_OPTICALDISK ICON_STR(LINEA_MUSIC_CD, "", "πŸ’Ώ")
#define ICON_PDF ICON_STR(FA_FILE_PDF_O, "󰈦", "πŸ“•")
#define ICON_PHOTOSHOP ICON_STR(DEV_PHOTOSHOP, "", ICON_PICTUREFILE)
#define ICON_PICTUREFILE ICON_STR(FA_FILE_IMAGE_O, "󰈟", ICON_PICTURES)
#define ICON_PHOTOSHOP ICON_STR(DEV_PHOTOSHOP, "", "πŸ–ŒοΈ ")
#define ICON_PICTUREFILE ICON_STR(FA_FILE_IMAGE_O, "󰈟", "πŸ–ΌοΈ ")
#define ICON_PICTURES ICON_STR(MD_CAMERA_ALT, "󰉔", "🎨")
#define ICON_PLAYLIST ICON_STR(ICON_MUSICFILE, "󱍙", "")
#define ICON_PLAYLIST ICON_STR(ICON_MUSICFILE, "󱍙", "🎢")
#define ICON_POWERPOINT ICON_STR(FILE_POWERPOINT, "󰈧", "πŸ“Š")
#define ICON_PUBLIC ICON_STR(FA_INBOX, "ξ—Ώ", "πŸ‘€")
#define ICON_PYTHON ICON_STR(MFIZZ_PYTHON, "", "🐍")
#define ICON_REACT ICON_STR(FILE_JSX, "ξ˜₯", ICON_JAVASCRIPT)
#define ICON_RUBY ICON_STR(MFIZZ_RUBY, "", "πŸ’Ž")
#define ICON_RUST ICON_STR(DEV_RUST, "", "")
#define ICON_SASS ICON_STR("", "ξ˜ƒ", "")
#define ICON_RUST ICON_STR(DEV_RUST, "", "πŸ¦€")
#define ICON_SASS ICON_STR("", "ξ˜ƒ", ICON_EXT_CSS)
#define ICON_SCRIPT ICON_STR(MFIZZ_SCRIPT, "ξž•", "πŸ“œ")
#define ICON_SUBTITLE ICON_STR(FA_COMMENTS_O, "σ°…Ί", "πŸ’¬")
#define ICON_TEMPLATES ICON_STR(FA_PAPERCLIP, "σ°—‡", "πŸ“Ž")
#define ICON_TEX ICON_STR(FILE_TEX, "σ°™©", ICON_DOCUMENT)
#define ICON_VIDEOFILE ICON_STR(FA_FILE_MOVIE_O, "󰈫", ICON_VIDEOS)
#define ICON_VIDEOS ICON_STR(FA_FILM, "󰈰", "🎞 ")
#define ICON_VIM ICON_STR(DEV_VIM, "", "")
#define ICON_VIDEOFILE ICON_STR(FA_FILE_MOVIE_O, "󰈫", "🎞 ")
#define ICON_VIDEOS ICON_STR(FA_FILM, "󰈰", "🎬")
#define ICON_VIM ICON_STR(DEV_VIM, "", "πŸͺ›")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the vim and πŸͺ› association.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vim is called "The power tool for everyone!" on their official website. https://www.vim.org/

#define ICON_WORDDOC ICON_STR(FILE_WORD, "󰈬", "πŸ“˜")

#define ICON_EXT_ASM ICON_STR(FILE_NASM, "", "")
#define ICON_EXT_BIN ICON_STR(OCT_FILE_BINARY, "ο‘±", "πŸ““")
#define ICON_EXT_COFFEE ICON_STR(MFIZZ_COFFEE_BEAN, "", "")
#define ICON_EXT_COFFEE ICON_STR(MFIZZ_COFFEE_BEAN, "", ICON_JAVASCRIPT)
#define ICON_EXT_CSS ICON_STR(MFIZZ_CSS3, "", "πŸ¦‹")
#define ICON_EXT_DEB ICON_STR(MFIZZ_DEBIAN, "", ICON_LINUX)
#define ICON_EXT_DEB ICON_STR(MFIZZ_DEBIAN, "", "πŸ₯")
#define ICON_EXT_DIFF ICON_STR(FILE_DIFF, "ο‘€", "πŸ“‹")
#define ICON_EXT_GO ICON_STR(MFIZZ_GO, "σ°Ÿ“", "")
#define ICON_EXT_GO ICON_STR(MFIZZ_GO, "σ°Ÿ“", "πŸ’¨")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how πŸ’¨ connects to go. Also, the previous comment about generic source code icon applies here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adressed in c299fe8

#define ICON_EXT_JSON ICON_STR(ICON_JAVASCRIPT, "ξ˜‹", ICON_JAVASCRIPT)
#define ICON_EXT_LUA ICON_STR(FILE_LUA, "", "🌘")
#define ICON_EXT_M ICON_STR("", "󰠞", "πŸ“Š")
#define ICON_EXT_MAT ICON_STR("", "οƒŽ", "")
#define ICON_EXT_MAT ICON_STR("", "οƒŽ", ICON_EXT_M)
#define ICON_EXT_MD ICON_STR(DEV_MARKDOWN, "ξ˜‰", "πŸ“")
#define ICON_EXT_MSI ICON_STR(FA_WINDOWS, "󰍲", "πŸͺŸ")
#define ICON_EXT_NIX ICON_STR("", "οŒ“", "")
#define ICON_EXT_NIX ICON_STR("", "οŒ“", "❄️ ")
#define ICON_EXT_PATCH ICON_STR(FILE_PATCH, "ο‘€", "🩹")
#define ICON_EXT_PHP ICON_STR(MFIZZ_PHP, "", "🌐")
#define ICON_EXT_ROM ICON_STR(FA_LOCK, "σ°Š–", "")
#define ICON_EXT_PHP ICON_STR(MFIZZ_PHP, "", ICON_HTML)
#define ICON_EXT_ROM ICON_STR(FA_LOCK, "σ°Š–", "πŸ”’")
#define ICON_EXT_RSS ICON_STR(FA_RSS_SQUARE, "ο…ƒ", "πŸ“‘")
#define ICON_EXT_RTF ICON_STR(ICON_PDF, "󰈦", ICON_PDF)
#define ICON_EXT_SCALA ICON_STR(MFIZZ_SCALA, "", "")
#define ICON_EXT_SLN ICON_STR(DEV_VISUALSTUDIO, "", "")
#define ICON_EXT_TS ICON_STR(FILE_TS, "", "")
#define ICON_EXT_TS ICON_STR(FILE_TS, "", ICON_JAVASCRIPT)


/*
Expand Down
Loading