O_EMOJI: Use a bigger variety of emoji #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the following icon definitions to use more specific emoji as icons. All of the new definitions are padded with spaces to ensure they use two cells each. ICON_CHESS "" -> "♟️ " (chess notation) ICON_FSHARP "" -> "🔷" (blue diamond looks like F Sharp logo) ICON_FONT "" -> "🔤" (letters abc) ICON_HTML "" -> "🌍" (globe) ICON_JAVASCRIPT "" -> ICON_SCRIPT (use a less generic emoji) ICON_MS_EXCEL ICON_WORDDOC -> "📗" (green book for Excel) ICON_MUSIC "🎧" (headphones and notes for music folder) ICON_MUSICFILE ICON_MUSIC -> "🎵" (one musical note for a song) ICON_PLAYLIST "" -> "🎶" (multiple notes for a playlist) ICON_PHOTOSHOP ICON_PICTUREFILE -> "🖌️ " (paintbrush symbolising photo editing) ICON_PICTUREFILE ICON_PICTURES -> "🖼️ " (a framed picture) ICON_RUST "" -> "🦀" (crab emoji looks like Rust mascot) ICON_SASS "" -> ICON_EXT_CSS (CSS preprocessor) ICON_VIDEOFILE ICON_VIDEOS -> "🎞 " (a film strip to symbolise a video) ICON_VIDEOS "🎞 " -> "🎬" (a clapper board for videos folder) ICON_VIM "" -> "🪛" (the power tool for everyone) ICON_EXT_COFFEE "" -> ICON_JAVASCRIPT (JS preprocessor) ICON_EXT_DEB ICON_LINUX -> "🍥" (Debian swirl) ICON_EXT_GO "" -> "💨" (Go logo dashing away) ICON_EXT_MAT "" -> ICON_EXT_M (MATLAB) ICON_EXT_NIX "" -> "❄️ " (Nix language logo like snowflake) ICON_EXT_PHP "🌐" -> ICON_HTML (use same Emoji for PHP and HTML) ICON_EXT_ROM "" -> "🔒" (a padlock) ICON_EXT_TS "" -> ICON_JAVASCRIPT (JS with static typing)
N-R-K
requested changes
Nov 6, 2024
src/icons.h
Outdated
| @@ -68,64 +68,64 @@ | |||
| #define ICON_DOWNLOADS ICON_STR(FA_DOWNLOAD, "", "📥") | |||
| #define ICON_ELIXIR ICON_STR(MFIZZ_ELIXIR, "", "💧") | |||
| #define ICON_ENCRYPT ICON_STR("", "", "🔒") | |||
| #define ICON_FSHARP ICON_STR(DEV_FSHARP, "", "") | |||
| #define ICON_FONT ICON_STR(FILE_FONT, "", "") | |||
| #define ICON_FSHARP ICON_STR(DEV_FSHARP, "", "🔷") | |||
There was a problem hiding this comment.
I think it's better to have a generic source code icon instead of using emojies which are vaguely similar.
There was a problem hiding this comment.
I see your point. I've adressed this in commit e4ea1fd
src/icons.h
Outdated
| #define ICON_VIM ICON_STR(DEV_VIM, "", "") | ||
| #define ICON_VIDEOFILE ICON_STR(FA_FILE_MOVIE_O, "", "🎞 ") | ||
| #define ICON_VIDEOS ICON_STR(FA_FILM, "", "🎬") | ||
| #define ICON_VIM ICON_STR(DEV_VIM, "", "🪛") |
There was a problem hiding this comment.
I don't get the vim and 🪛 association.
There was a problem hiding this comment.
Vim is called "The power tool for everyone!" on their official website. https://www.vim.org/
src/icons.h
Outdated
| #define ICON_EXT_DIFF ICON_STR(FILE_DIFF, "", "📋") | ||
| #define ICON_EXT_GO ICON_STR(MFIZZ_GO, "", "") | ||
| #define ICON_EXT_GO ICON_STR(MFIZZ_GO, "", "💨") |
There was a problem hiding this comment.
I don't get how 💨 connects to go. Also, the previous comment about generic source code icon applies here.
|
@N-R-K please merge when ready. |
|
Thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the following icon definitions to use more specific emoji as icons. All of the new definitions are padded with spaces to ensure they use two cells each.