-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to spawn different assets in environments and spawn randomizations #895
Conversation
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/multi_asset/multi_asset.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these only work for multi_asset spawners? If it can be used by other spawners should we move them out to the spawners or sim directory for easier access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should rather be at the same positions as the modifiers for the observations? Both concepts are very close to each other. @Mayankm96 @Dhoeller19 @jsmith-bdai any opinions?
.../omni.isaac.lab/omni/isaac/lab/sim/spawners/multi_asset/randomizations/randomizations_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/multi_asset/asset_randomizer.py
Outdated
Show resolved
Hide resolved
Co-authored-by: jtigue-bdai <[email protected]> Signed-off-by: Pascal Roth <[email protected]>
@Mayankm96 @Dhoeller19 @jsmith-bdai ping again about that PR and the discussion above |
@pascal-roth We'll look at this for the next release. Our hands are packed with more pressing tasks for the current release. Thanks for the effort on this! |
Okay so I went over this MR and it seems to be mixing two different notions IMO:
I think these two can be separated out as two concepts since randomizing asset properties is independent of how you spawn it. After doing some more testing on my side, we can simplify Step 1 more. I made an MR #1164 in that direction. Would love to hear your thoughts. For Step 2, I propose that we should make a new mode in the event manager. It will come at some cost over repeated for loops, but the code simplification is worth it, in my opinion. |
@Mayankm96 thanks for the feedback, will adjust it accordingly |
Description
This PR introduces the option to spawn multiple assets in the same environment (e.g. env_0 has a sphere and env_1 a cube). Originally developed by @renezurbruegg
It additionally introduces Spawn Randomizations which are applied when an asset is spawned.
This allows to Randomize properties such as joint offsets and scales, which is otherwise not possible with only reset randomization.
Run
./isaaclab -p source/standalone/demos/multi_object.py
or
./isaaclab -p source/standalone/demos/multi_object.py --randomize
to see an example (Screenshot)
Example Configuration:
Example Config to also Randomize Scales:
Type of change
Screenshots
Example for different Assets
./isaaclab -p source/standalone/demos/multi_object.py
Example for different Assets with scale randomizations
./isaaclab -p source/standalone/demos/multi_object.py --randomize
./isaaclab -p source/standalone/demos/multi_object.py
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
./isaaclab.sh --test
and they passconfig/extension.toml
fileCONTRIBUTORS.md
or my name already exists there