Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OperationSpaceController to docs and tests #879

Closed
wants to merge 1 commit into from

Conversation

jtigue-bdai
Copy link
Collaborator

Description

This PR add the OperationSpaceController to the docs and provides some test for its parameteric features.

Fixes #873

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jtigue-bdai jtigue-bdai self-assigned this Aug 26, 2024
@jtigue-bdai jtigue-bdai added the documentation Improvements or additions to documentation label Aug 26, 2024
@jtigue-bdai jtigue-bdai changed the title Add OperationSpaceControl to docs and tests Add OperationSpaceController to docs and tests Aug 26, 2024
@ozhanozen
Copy link
Contributor

@jtigue-bdai, shall we also include in this PR, adding a corresponding action class, i.e., OperationSpaceControllerAction/Cfg, here? This would be nice for being able to interface it with the action manager, and such exist for other controllers.

@jtigue-bdai
Copy link
Collaborator Author

Yeah I think that would be a good addition with this effort.

@pascal-roth pascal-roth added the dev team Issue or pull request created by the dev team label Aug 28, 2024
@ozhanozen
Copy link
Contributor

@jtigue-bdai At the moment I do not have push access to this PR branch.

Would you prefer I create a new PR from my own fork to integrate into this PR (so there would be two different PRs for the same topic), or would you like to give me push access to this branch? If you will give access, could you do it for both @ozhanozen and @sbtc-sipbb?

@jtigue-bdai
Copy link
Collaborator Author

Sorry @ozhanozen my intention was for you to push to this branch, but let me check with the dev team this morning and I will get back to you.

@jtigue-bdai
Copy link
Collaborator Author

@ozhanozen I talked with the team. Because this repo is setup within the isaac-sim org, the best way moving forward will be to have you create the PR from your fork and to the isaac-sim/isaac-lab. We can then just close this one and I can give you reviews you your branch.

Sorry for the confusion, I didn't realize some of the restrictions we had setup.

@ozhanozen
Copy link
Contributor

@jtigue-bdai no problem. I have created a new PR from my fork, #913, as you suggested, and we can work on it.

You can close this PR.

@jtigue-bdai
Copy link
Collaborator Author

Closing in favor of #913 for OS user contributions

@jtigue-bdai jtigue-bdai closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev team Issue or pull request created by the dev team documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Implementation status of the operational space and joint impedance controllers
3 participants