Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noise_model initialized in direct_marl_env #1480

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NoneJou072
Copy link

@NoneJou072 NoneJou072 commented Nov 29, 2024

Description

This change fixes bugs in DirectMARLEnv class, where previously _action_noise_model and _observation_noise_model cannot successfully initialized when the noise-model-cfg passed in.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

zhouhaoran added 2 commits November 29, 2024 10:27
Change-Id: If8238d7ddfbec9b8c3b2c7cfe75619bd2fe8a4d1
Change-Id: Ic9c2d4ae77295726c59078b2547388eebf53ee31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant