Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gym.Env to DirectMARLEnv for Gymnasium v1.0.0 #1446

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

kellyguo11
Copy link
Contributor

@kellyguo11 kellyguo11 commented Nov 21, 2024

Description

Due to recent release of Gymnasium 1.0.0, this now becomes the Gymnasium version that gets installed when running the installation process for Isaac Lab. Gymnasium 1.0.0 requires all environments to be a subclass of gym.Env when using the make interface. This change makes the DirectMARLEnv a subclass of gym.Env to satisfy this requirement.

Fixes #1002

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 marked this pull request as draft November 21, 2024 17:34
@kellyguo11 kellyguo11 marked this pull request as ready for review November 21, 2024 18:35
@kellyguo11 kellyguo11 changed the title Adds gym.Env to DirectMARLEnvCfg for Gymnasium v1.0.0 Adds gym.Env to DirectMARLEnv for Gymnasium v1.0.0 Nov 21, 2024
@kellyguo11 kellyguo11 merged commit 64dc874 into isaac-sim:main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Relaxing gymnasium requirement
1 participant