Adds check that no articulation root API is applied on rigid bodies #1358
+63
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgulich
requested review from
jsmith-bdai,
pascal-roth,
kellyguo11,
Dhoeller19,
Mayankm96,
jtigue-bdai and
hhansen-bdai
as code owners
lgulich
force-pushed
the
lgulich/ignore-articulation-when-loading-rigid-body
branch
from
5bd8c3c
to
a2608bf
Compare
Dhoeller19
changed the title
Dhoeller19
approved these changes
Nov 1, 2024
|
@lgulich could you please update the changelog, mentioning why this was done |
Mayankm96
reviewed
Nov 4, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/assets/rigid_object/rigid_object.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Nov 4, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/assets/rigid_object/rigid_object.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Nov 4, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/assets/rigid_object/rigid_object.py
Outdated
Show resolved
Hide resolved
Mayankm96
approved these changes
Nov 4, 2024
lgulich
force-pushed
the
lgulich/ignore-articulation-when-loading-rigid-body
branch
from
67fcdbf
to
ec93ab3
Compare
lgulich
changed the title
lgulich
force-pushed
the
lgulich/ignore-articulation-when-loading-rigid-body
branch
from
ec93ab3
to
a98a896
Compare
lgulich
force-pushed
the
lgulich/ignore-articulation-when-loading-rigid-body
branch
from
a98a896
to
d5bba66
Compare
…id-body Signed-off-by: lgulich <[email protected]>
Dhoeller19
reviewed
Nov 5, 2024
Signed-off-by: David Hoeller <[email protected]>
Dhoeller19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a USD contains an articulation root but we load it with a
RigidObjectCfgthis would also load the articulation. This is confusing as a user only expects a rigid body.This PR adds a fix to ignore the articulation if a rigid body is spawned.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there