-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds image extracted features observation term and cartpole examples for it #1191
Adds image extracted features observation term and cartpole examples for it #1191
Conversation
Signed-off-by: glvov-bdai <[email protected]>
Signed-off-by: glvov-bdai <[email protected]>
Signed-off-by: glvov-bdai <[email protected]>
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
Signed-off-by: garylvov <[email protected]>
Signed-off-by: glvov-bdai <[email protected]>
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
Signed-off-by: glvov-bdai <[email protected]>
…ub.com/glvov-bdai/IsaacLab into feature/preprocess_observation_updated
Signed-off-by: glvov-bdai <[email protected]>
Signed-off-by: glvov-bdai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks! Please update the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, thanks for adding! Just left some minor comments.
Just curious - how do you ensure the models are frozen? I didn't see it configured anywhere
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/observations.py
Show resolved
Hide resolved
…vations.py Co-authored-by: James Smith <[email protected]> Signed-off-by: glvov-bdai <[email protected]>
@jsmith-bdai Feature extraction encoders are frozen due to the .eval() flag in the model creation, like in
Anyways, even if they weren't in eval mode I think they would still be frozen as I don't back-propogate the loss anywhere with model so weights shouldn't update |
Signed-off-by: glvov-bdai <[email protected]>
…for it (isaac-sim#1191) # Description This adds an observation term to be able to easily extract features from the images, and adds a cartpole example of using this new term. The new ResNet18 cartpole converges in less than 100 epochs. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there I will update the version in the changelog and extension.toml after approval prior to merging in due to it causing merge conflicts when main updates --------- Signed-off-by: glvov-bdai <[email protected]> Signed-off-by: garylvov <[email protected]> Co-authored-by: garylvov <[email protected]> Co-authored-by: garylvov <[email protected]> Co-authored-by: David Hoeller <[email protected]> Co-authored-by: James Smith <[email protected]>
…for it (isaac-sim#1191) # Description This adds an observation term to be able to easily extract features from the images, and adds a cartpole example of using this new term. The new ResNet18 cartpole converges in less than 100 epochs. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there I will update the version in the changelog and extension.toml after approval prior to merging in due to it causing merge conflicts when main updates --------- Signed-off-by: glvov-bdai <[email protected]> Signed-off-by: garylvov <[email protected]> Co-authored-by: garylvov <[email protected]> Co-authored-by: garylvov <[email protected]> Co-authored-by: David Hoeller <[email protected]> Co-authored-by: James Smith <[email protected]>
Description
This adds an observation term to be able to easily extract features from the images, and adds a cartpole example of using this new term.
The new ResNet18 cartpole converges in less than 100 epochs.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists thereI will update the version in the changelog and extension.toml after approval prior to merging in due to it causing merge conflicts when main updates