-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inertia.js v2.0 compatibility #132
Open
skryukov
wants to merge
37
commits into
inertiajs:master
Choose a base branch
from
skryukov:v2/all
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+971
β311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this alone, the same Rails app could serve different Inertia apps, setting a different version for each one in base controllers.
Also, rename it to `inertia_ssr_head`, which is a better description.
Shared data is now frozen to prevent Also, match the method names for instance variables. Updated a test that used to call `inertia_share` inside a `before_action` as that seems like something a user should never do.
I have created a PR into your fork to solve |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR based on work from #121 and #130 and aims to add full Inertia.js v2.0 compatibility (because I want to have a branch to play with the beta π).
It includes:
DeferredProp
β from [V2] Deferred PropsΒ #130inertia_config
to enable controller-specific configΒ #121OptionalProp
- an alias for a deprecatedLazyProp
MergeProp
AlwaysProp
from Inertia 1.2X-Inertia-Partial-Except
from Inertia 1.2InertiaRails.lazy(nil)
andInertiaRails.lazy(false)
Updated documentation: skryukov/inertia_rails-contrib#21
TODO:
#131