-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute hc login on first run #95
Conversation
This ensures we don't put errors inside devices.json file.
for more information, see https://pre-commit.ci
Looks good to me. Maybe you really can remove jq from the docker file. My search result said, that we does not use it elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to test yet, would be good practice to validate the checksum on the dependency download in docker
I just checked and it's used in bashio. So we need to keep it. |
This PR aims to execute hc-login.py directly on first run of home assistant add-on. Two new text inputs has been added to HA addon configuration (HC email & password) and will be passed to hc-login.py.
Resolves:
Notable changes