Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refuse to process malformed SSH public key files #111

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Refuse to process malformed SSH public key files #111

wants to merge 1 commit into from

Commits on Feb 20, 2019

  1. Refuse to process malformed SSH public key files. 

    If the user specifies a file that looks like an SSH public key file,
but it does not contain exactly one SSH public key (either it contains
none or the fingerprint is wrong or there is another key appended at
the end), keychain will misinterpret the "fingerprint" of the key file
and always try to load the corresponding private key.  This may lead
to repeated passphrase prompts and general user confusion.

A trivial way to reproduce this is to append a second line containing
the fingerprint of another SSH public key to a keyfile.

Debian bug:	https://bugs.debian.org/673019
Reported by:	Ryan Kavanagh <[email protected]>
    @ppentchev
    ppentchev committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    2722fdc View commit details
    Browse the repository at this point in the history