Refuse to process malformed SSH public key files #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user specifies a file that looks like an SSH public key file, but it does not contain exactly one SSH public key (either it contains none or the fingerprint is wrong or there is another key appended at the end), keychain will misinterpret the "fingerprint" of the key file and always try to load the corresponding private key. This may lead to repeated passphrase prompts and general user confusion. A trivial way to reproduce this is to append a second line containing the fingerprint of another SSH public key to a keyfile. Debian bug: https://bugs.debian.org/673019 Reported by: Ryan Kavanagh <[email protected]>
|
hello, @ppentchev - first of all thank you for the PR and sorry that someone responded after >3 years the reason why your PR didn't get any attention is that this is a mirror repository. Funtoo Linux contribution process happens via https://code.funtoo.org if you're still interested in contributing to Funtoo Linux you might be interested in this links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Thanks for keeping keychain alive!
What do you think about this change that improves its behavior when pointed at an almost-valid SSH public key file?
Thanks in advance, and keep up the great work!
G'luck,
Peter