Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: NSSF app, sbi, processor, consumer #24

Merged
merged 32 commits into from
Jun 27, 2024
Merged

refactor: NSSF app, sbi, processor, consumer #24

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e8eac91
refactor: sbi server
yccodr Apr 24, 2024
8210039
refactor: processor as route handler
yccodr Apr 25, 2024
d866a36
fix: nil dereference
yccodr Apr 25, 2024
99a72d3
fix: ci complains
yccodr Apr 25, 2024
9bbfecf
refactor: interface design
yccodr Apr 25, 2024
6f939e0
test: nssaiavailability `NfInstanceDelete`
yccodr Apr 25, 2024
e9e39ad
feat: graceful shutdown sbi server
yccodr Apr 25, 2024
155556c
fix: loop dependency on nssf app interface
yccodr Apr 29, 2024
fdee497
fix: missing oauth check
yccodr Apr 29, 2024
5838a20
fix: Init NSSF context
andy89923 Apr 29, 2024
cfe9ecd
chore: change logger to align with the right context
yccodr Apr 29, 2024
e6953eb
refactor: add services only when they are configured
yccodr Apr 29, 2024
25fe2c1
Revert "fix: loop dependency on nssf app interface"
yccodr Apr 30, 2024
db71e05
refactor: general app interface
yccodr May 8, 2024
01f38b7
refactor: app statr interface
yccodr May 8, 2024
6d27b3a
refactor: consumer
yccodr May 8, 2024
8a74e48
fix: should not access nssf context before assignment
yccodr May 9, 2024
4488ffb
feat: register procedure graceful shutdown
yccodr May 9, 2024
7f4cf20
fix: init nssf context with wrong function
yccodr May 9, 2024
b00f843
refactor: align naming of route handler
yccodr May 9, 2024
0ed8569
refactor: processor architecture that aligns with other nf repo
yccodr May 10, 2024
4700f68
refactor: nssf context init function
yccodr May 10, 2024
d666c0b
fix: duplicate processor
yccodr May 20, 2024
18cbb37
fix: magic number
yccodr May 20, 2024
54d7510
fix: possibly -1 in index range
yccodr May 20, 2024
f0b8da4
fix: linter complains
yccodr May 20, 2024
277815f
fix: instantiate processor in `NewApp()`
yccodr Jun 4, 2024
d1e1d5f
chore: add comment
yccodr Jun 11, 2024
5827322
chore: fix typo
yccodr Jun 12, 2024
d04c2e4
refactor: create context before `NewApp`
yccodr Jun 14, 2024
0e29e65
fix(nsselection): if `tai` and `homePlmnId` are both missing, return 400
yccodr Jun 14, 2024
201cb73
fix: prevent `app.Terminate()` being called twice
yccodr Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/service/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ func NewApp(cfg *factory.Config, tlsKeyLogPath string) (*NssfApp, error) {
nssf.SetLogLevel(cfg.GetLogLevel())
nssf.SetReportCaller(cfg.GetLogReportCaller())

processor := processor.NewProcessor(nssf)
yccodr marked this conversation as resolved.
Show resolved Hide resolved
nssf.processor = processor

consumer := consumer.NewConsumer(nssf)
nssf.consumer = consumer

Expand Down