Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: NSSF app, sbi, processor, consumer #24

Merged
merged 32 commits into from
Jun 27, 2024
Merged

refactor: NSSF app, sbi, processor, consumer #24

merged 32 commits into from
Jun 27, 2024

Conversation

yccodr
Copy link
Contributor

@yccodr yccodr commented Apr 25, 2024 •
edited by andy89923
Loading

Description

  • Refactor: Nssf App, SBI Server, Processor, Consumer

TODO

  • Test UE connection

@andy89923
Copy link
Contributor

I think you forgot NewRouterAuthorizationCheck.

andy89923
andy89923 previously approved these changes Apr 29, 2024
View reviewed changes
andy89923
andy89923 reviewed Apr 30, 2024
View reviewed changes
pkg/service/init.go Outdated Show resolved Hide resolved
@andy89923 andy89923 dismissed their stale review May 6, 2024 13:31

not ready

@yccodr yccodr changed the title Refactor NSSF app, sbi, processor Refactor NSSF app, sbi, processor, consumer May 9, 2024
@yccodr yccodr requested a review from andy89923 May 9, 2024 12:06
@ianchen0119
Copy link
Contributor

Overall, it looks good to me.

@andy89923 andy89923 changed the title Refactor NSSF app, sbi, processor, consumer refactor: NSSF app, sbi, processor, consumer May 13, 2024
ianchen0119
ianchen0119 reviewed May 20, 2024
View reviewed changes
pkg/service/init.go Outdated Show resolved Hide resolved
ianchen0119
ianchen0119 reviewed May 20, 2024
View reviewed changes
internal/sbi/server.go Outdated Show resolved Hide resolved
@andy89923
Copy link
Contributor

Overall, LGTM🧑🏻‍💻

@blackcat-118
Copy link

LGTM.

ianchen0119
ianchen0119 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ianchen0119 ianchen0119 merged commit a73f10f into free5gc:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackcat-118 blackcat-118 blackcat-118 left review comments

@ianchen0119 ianchen0119 ianchen0119 approved these changes

@andy89923 andy89923 andy89923 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yccodr @andy89923 @ianchen0119 @blackcat-118