Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get/Set formats in a distro-agnostic way #140

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Conversation

davidmhewitt
Copy link
Member

@davidmhewitt davidmhewitt commented Oct 3, 2021

Fixes #76

Means we can get/set the user's format preference in a way that works on non-Ubuntu based distributions. I've tested that this has no effect on elementary but means that the plug correctly detects and allows you to change format settings on Fedora.

To test:

  • Change the "Formats" property in the plug
  • Log out, log in again
  • Check that new formats have applied (e.g. date format in wingpanel has changed, language has remained the same)

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks for fixing this

@danirabbit danirabbit enabled auto-merge (squash) October 15, 2021 16:41
@danirabbit danirabbit merged commit fb089ee into master Oct 15, 2021
@danirabbit danirabbit deleted the distro-agnostic-region branch October 15, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

plug cannot determine region and format correctly on fedora
2 participants