Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_STATIC_PEERS #334

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Support ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_STATIC_PEERS #334

merged 3 commits into from
Nov 25, 2024

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Nov 13, 2024

Deal with #311

@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'bug', 'internal', 'breaking-change', 'new feature', 'dependencies', 'documentation', 'enhancement'}

@evshary evshary added the enhancement New feature or request label Nov 13, 2024
@evshary evshary requested a review from JEnoch November 13, 2024 06:17
@evshary
Fix the coding style format.
6ee4f86 
Signed-off-by: ChenYing Kuo <[email protected]>
JEnoch
JEnoch requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the README.md is mentioning ROS_LOCALHOST_ONLY=1 usage. It should be updated with something like:
use ROS_AUTOMATIC_DISCOVERY_RANGE=LOCALHOST after Iron and ROS_LOCALHOST_ONLY=1 before Iron

zenoh-plugin-ros2dds/src/config.rs Outdated Show resolved Hide resolved
zenoh-plugin-ros2dds/src/config.rs Outdated Show resolved Hide resolved
zenoh-plugin-ros2dds/src/lib.rs Show resolved Hide resolved
zenoh-plugin-ros2dds/src/lib.rs Show resolved Hide resolved
@evshary evshary requested a review from JEnoch November 25, 2024 06:09
@JEnoch JEnoch merged commit 864a532 into eclipse-zenoh:main Nov 25, 2024
6 checks passed
@JEnoch JEnoch mentioned this pull request Nov 25, 2024
Closed
@evshary evshary deleted the support_new_dynamic_discovery branch November 26, 2024 02:17
@gabrik
Copy link
Contributor

gabrik commented Nov 27, 2024

@RemiBarthe 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEnoch JEnoch JEnoch approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evshary @gabrik @JEnoch