Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_STATIC_PEERS #311

Closed
evshary opened this issue Oct 23, 2024 · 3 comments
Closed

Support ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_STATIC_PEERS #311

evshary opened this issue Oct 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@evshary
Copy link
Contributor

evshary commented Oct 23, 2024

Describe the feature

Based on the description on the description of Dynamic Discovery, we might need to make some apropriate changes.
https://docs.ros.org/en/rolling/Tutorials/Advanced/Improved-Dynamic-Discovery.html#id4

  1. ROS_LOCALHOST_ONLY will be deprecated in the future, but to ensure the backward compatibility, --ros-localhost-only should be kept and perhaps show warning to users if they are using ROS 2 Iron or later.
  2. Now we have both ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_STATIC_PEERS environmental variables and will affect the DDS configuration. We might also need to support these two arguments --ros-automatic-discovery-range and --ros-static-peers.

@JEnoch I would like to know your thoughts about this.

@evshary
Copy link
Contributor Author

evshary commented Oct 23, 2024

We can refer to rmw_cyclonedds_cpp for the DDS configuration.

@evshary evshary added the enhancement New feature or request label Oct 23, 2024
@evshary evshary changed the title Support ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_AUTOMATIC_DISCOVERY_RANGE Support ROS_AUTOMATIC_DISCOVERY_RANGE and ROS_STATIC_PEERS Oct 23, 2024
@evshary evshary self-assigned this Nov 8, 2024
@evshary
Copy link
Contributor Author

evshary commented Nov 8, 2024

@JEnoch, since we agreed on the proposal during the meeting, I will start implementing it.

@JEnoch
Copy link
Member

JEnoch commented Nov 25, 2024

Implemented in #334 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants