Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing #5480

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Dec 10, 2024

Description

This PR adds the flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing.
In particular, it

  • Adds the required infrastructure to include environment args splitting them to be recognized as different argv in windows.
  • Includes a new matched argument to the rtps example to wait for discovery before publishing.
  • Adds a new argument samples to the subscriber content filter as a finish condition when it gets unmatched.

Note: In the content filter example the PUB_ARGS was removed since it was not being used in the compose file.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • [X ] Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Dec 10, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima December 10, 2024 16:05
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant