Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22321] Benchmark example updated #5460

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Javgilavi
Copy link
Contributor

@Javgilavi Javgilavi commented Dec 4, 2024

Description

I remake the benchmark example to new example style maintaining the original functionality.

@Mergifyio backport 3.1.x 3.0.x

Fixes #5398

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Javgilavi Javgilavi added this to the v3.2.0 milestone Dec 4, 2024
@Javgilavi Javgilavi requested a review from Mario-DL December 9, 2024 06:21
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 9, 2024
Copy link
Contributor

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending example tests

@Javgilavi Javgilavi force-pushed the feature/benchmark-example branch from 4c8a8db to 54b8494 Compare December 11, 2024 08:48
@rsanchez15 rsanchez15 requested review from Mario-DL and removed request for Mario-DL December 11, 2024 09:58
Signed-off-by: Javier Gil Aviles <[email protected]>
@Javgilavi Javgilavi requested review from Mario-DL and removed request for Mario-DL December 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no benchmark example? and incorrect doc instructions
2 participants