Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMR: Use pipelineArtifact upload method for final join outputs #45221

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions eng/pipelines/templates/stages/vmr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1389,19 +1389,19 @@ stages:
templateContext:
outputParentDirectory: $(Build.ArtifactStagingDirectory)/artifacts
outputs:
- output: buildArtifacts
PathtoPublish: $(Build.ArtifactStagingDirectory)/artifacts/MergedManifest.xml
ArtifactName: AssetManifests
- output: pipelineArtifact
targetPath: $(Build.ArtifactStagingDirectory)/artifacts/MergedManifest.xml
artifactName: AssetManifests
displayName: Publish Merged Manifest
sbomEnabled: false
Comment on lines +1392 to 1396
Copy link
Member

@ViktorHofer ViktorHofer Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every job writes into the AssetManifests folder. Does that work with a pipeline artifact?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no they don't, we only write into the VerticalManifests artifact in the VMR build.

- output: buildArtifacts
PathtoPublish: $(Build.ArtifactStagingDirectory)/artifacts/assets
ArtifactName: BlobArtifacts
- output: pipelineArtifact
targetPath: $(Build.ArtifactStagingDirectory)/artifacts/assets
artifactName: BlobArtifacts
displayName: Publish Blob Artifacts
sbomEnabled: false
- output: buildArtifacts
PathtoPublish: $(Build.ArtifactStagingDirectory)/artifacts/packages
ArtifactName: PackageArtifacts
- output: pipelineArtifact
targetPath: $(Build.ArtifactStagingDirectory)/artifacts/packages
artifactName: PackageArtifacts
displayName: Publish Package Artifacts
sbomEnabled: false
steps:
Expand Down